Skip to content

ci(app-onboard): run the app-onboard checks on PRs - #2414

Merged
Dani Akash (DaniAkash) merged 2 commits into
epic/app-onboardfrom
ci/app-onboard-checks
Aug 21, 2026
Merged

ci(app-onboard): run the app-onboard checks on PRs#2414
Dani Akash (DaniAkash) merged 2 commits into
epic/app-onboardfrom
ci/app-onboard-checks

Conversation

@DaniAkash

Copy link
Copy Markdown
Contributor

The app-onboard app was not wired into CI, so a PR touching it reported "0 suites affected" and never ran its tests (noticed on the app-onboard flow PR).

What

  • Tests: register an app-onboard suite in ci/affected-suites.ts (mirrors claw-onboard) plus its package mapping, so the Tests workflow runs bun run test when the app is affected. Verified locally: the suite command runs all 64 tests and writes the JUnit the summary table reads.
  • Quality gates: add epic/app-onboard to code-quality.yml's branch list so Biome, Typecheck (Turbo --affected), and Fallow run on the epic PRs too (they were gated to main).
  • Updated the suite-mapping unit test (per-package case + the all-suites case).

Editing ci/ is a harness change, so this run exercises the full matrix and self-verifies the discovery, including the new app-onboard suite (now present on the epic branch).

Follow-up (not in this PR)

No workflow runs build:chromium (the WebUI resource verifier) at PR time for either onboarding app; it is release-only. Worth adding as a PR check for both claw-onboard and app-onboard so a resource-contract violation is caught before release, but that is a separate, project-wide change.

The Tests workflow discovers suites from ci/affected-suites.ts, and
app-onboard was not registered, so a PR touching it reported "0 suites
affected" and never ran its tests. Add an app-onboard suite (mirrors
claw-onboard) plus its package mapping so `bun run test` runs when the
app is affected, and add epic/app-onboard to code-quality's branch list
so Biome, Typecheck (Turbo --affected), and Fallow run on the epic PRs
too. Editing ci/ is a harness change, so this run exercises the full
matrix and self-verifies the discovery.
@github-actions github-actions Bot added the CI/CD label Aug 21, 2026
@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR wires the app-onboard test suite into affected-suite discovery and enables code-quality checks for pull requests targeting the app-onboard epic branch.

  • Adds the app-onboard test command, JUnit output, and package-to-suite mapping.
  • Extends mapping tests to cover direct app-onboard changes and the complete package-owned suite set.
  • Adds epic/app-onboard to the code-quality workflow’s pull-request branches.

Confidence Score: 5/5

The PR appears safe to merge, with the new suite and workflow trigger aligned with the repository’s existing CI conventions.

The app-onboard workspace name, test command, JUnit output path, and runner requirements match the new suite configuration, and the workflow branch and path filters cover the stated epic pull requests.

Important Files Changed

Filename Overview
.github/workflows/code-quality.yml Adds the app-onboard epic branch to the existing code-quality pull-request trigger without changing job behavior.
packages/browseros-agent/ci/affected-suites.ts Registers the app-onboard suite with a valid package mapping, test command, JUnit path, and appropriate environment flags.
packages/browseros-agent/ci/affected-suites.test.ts Covers direct app-onboard suite selection and includes the package in the complete package-owned suite assertion.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  PR[Pull request changes] --> Discover[Turbo affected-package discovery]
  Discover --> Map[Package-to-suite mapping]
  Map --> Suite[app-onboard test suite]
  Suite --> JUnit[JUnit report]
  PR -->|base: epic/app-onboard| Quality[Biome, typecheck, and Fallow]
Loading

Reviews (1): Last reviewed commit: "ci(app-onboard): run the app-onboard che..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

✅ Tests passed: 2571/2574

Ran 16 of 16 suites (0 not affected by this change).

Suite Passed Failed Skipped
server-agent 290/290 0 0
server-api 157/157 0 0
server-tools 254/254 0 0
server-browser 10/10 0 0
server-integration 10/10 0 0
server-lib 120/120 0 0
server-root 38/41 0 3
agent 316/316 0 0
claw-app 392/392 0 0
claw-onboard 86/86 0 0
app-onboard 64/64 0 0
build 44/44 0 0
release 65/65 0 0
claw-server-rust 616/616 0 0
claw-server-rust-quality passed 0 0
claw-mcp 109/109 0 0

passed = ran successfully but emits no JUnit counts (a lint/format gate).

View workflow run

@DaniAkash
Dani Akash (DaniAkash) merged commit a00602d into epic/app-onboard Aug 21, 2026
7 of 8 checks passed
@DaniAkash
Dani Akash (DaniAkash) deleted the ci/app-onboard-checks branch August 21, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant