ci(app-onboard): run the app-onboard checks on PRs - #2414
Merged
Conversation
The Tests workflow discovers suites from ci/affected-suites.ts, and app-onboard was not registered, so a PR touching it reported "0 suites affected" and never ran its tests. Add an app-onboard suite (mirrors claw-onboard) plus its package mapping so `bun run test` runs when the app is affected, and add epic/app-onboard to code-quality's branch list so Biome, Typecheck (Turbo --affected), and Fallow run on the epic PRs too. Editing ci/ is a harness change, so this run exercises the full matrix and self-verifies the discovery.
Contributor
Greptile SummaryThis PR wires the app-onboard test suite into affected-suite discovery and enables code-quality checks for pull requests targeting the app-onboard epic branch.
Confidence Score: 5/5The PR appears safe to merge, with the new suite and workflow trigger aligned with the repository’s existing CI conventions. The app-onboard workspace name, test command, JUnit output path, and runner requirements match the new suite configuration, and the workflow branch and path filters cover the stated epic pull requests. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
PR[Pull request changes] --> Discover[Turbo affected-package discovery]
Discover --> Map[Package-to-suite mapping]
Map --> Suite[app-onboard test suite]
Suite --> JUnit[JUnit report]
PR -->|base: epic/app-onboard| Quality[Biome, typecheck, and Fallow]
Reviews (1): Last reviewed commit: "ci(app-onboard): run the app-onboard che..." | Re-trigger Greptile |
Contributor
✅ Tests passed: 2571/2574Ran 16 of 16 suites (0 not affected by this change).
|
Dani Akash (DaniAkash)
merged commit Aug 21, 2026
a00602d
into
epic/app-onboard
7 of 8 checks passed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
app-onboardapp was not wired into CI, so a PR touching it reported "0 suites affected" and never ran its tests (noticed on the app-onboard flow PR).What
app-onboardsuite inci/affected-suites.ts(mirrorsclaw-onboard) plus its package mapping, so the Tests workflow runsbun run testwhen the app is affected. Verified locally: the suite command runs all 64 tests and writes the JUnit the summary table reads.epic/app-onboardtocode-quality.yml's branch list so Biome, Typecheck (Turbo--affected), and Fallow run on the epic PRs too (they were gated tomain).Editing
ci/is a harness change, so this run exercises the full matrix and self-verifies the discovery, including the new app-onboard suite (now present on the epic branch).Follow-up (not in this PR)
No workflow runs
build:chromium(the WebUI resource verifier) at PR time for either onboarding app; it is release-only. Worth adding as a PR check for bothclaw-onboardandapp-onboardso a resource-contract violation is caught before release, but that is a separate, project-wide change.