Fix the six error-path crashes from the revival findings - #771
Merged
Conversation
gronke
commented
Jul 8, 2026
gronke
commented
Member
- A failed download of the end-of-life release list logs the intended warning instead of raising a TypeError.
- The Provisioner raises the new InvalidProvisionerMethod error for an unknown provision.method value instead of crashing with an AttributeError.
- A failed release asset hash check raises InvalidReleaseAssetSignature instead of a TypeError, and the failure is now logged like the other update errors.
- Applying standalone storage reaches its intended NotImplementedError instead of a TypeError from an unsupported Logger argument.
- Applying ZFS basejail storage yields the BasejailStorageConfig event instead of crashing on a typo, and forwards the event scope like the NullFS backend.
- Destroying a network interface runs ifconfig destroy through libioc.helpers.exec instead of referencing the non-existent libioc.helper module.
The handler passed a topic argument that DownloadFailed does not take and selected the warning log level that the Logger does not offer, so it raised a TypeError before the warning could appear. The error is constructed without being raised, which logs the warning and lets the release list degrade to empty.
The Provisioner raises it for an unknown provision.method value, but the class never existed, so the raise statement crashed with an AttributeError.
A failed asset hash check passed a release_name argument that the error does not take and therefore crashed with a TypeError. The error now also forwards the logger, so the failure is logged like the other update errors.
Logger.warn takes no jail argument, so applying standalone storage crashed with a TypeError before reaching its intended NotImplementedError.
The apply generator referenced the event class with a typo and crashed with an AttributeError. It now also forwards the event scope like the NullFS backend.
The destroy path referenced the non-existent libioc.helper module and crashed before running ifconfig destroy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.