Skip to content

refactor: remove Slide.error from core#55

Merged
leoafarias merged 2 commits intorelease/nextfrom
leoafarias/remove-slide-error
Mar 11, 2026
Merged

refactor: remove Slide.error from core#55
leoafarias merged 2 commits intorelease/nextfrom
leoafarias/remove-slide-error

Conversation

@leoafarias
Copy link
Collaborator

Summary

  • remove the unused Slide.error(...) factory from superdeck_core
  • delete the corresponding Slide model tests
  • document the public API removal in packages/core/CHANGELOG.md

Validation

  • cd packages/core && fvm exec dart test test/src/models/slide_model_test.dart test/src/models/block_model_test.dart
  • cd packages/builder && fvm exec dart test test/src/parsers/section_parser_test.dart test/src/parsers/block_parser_test.dart
  • rg -n "Slide\.error" /Users/leofarias/conductor/workspaces/superdeck/riyadh-v1

Copilot AI review requested due to automatic review settings March 11, 2026 15:10
@docs-page
Copy link

docs-page bot commented Mar 11, 2026

To view this pull requests documentation preview, visit the following URL:

docs.page/btwld/superdeck~55

Documentation is deployed and generated using docs.page.

@leoafarias leoafarias merged commit a6f14b9 into release/next Mar 11, 2026
1 check passed
@leoafarias leoafarias deleted the leoafarias/remove-slide-error branch March 11, 2026 15:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused Slide.error(...) factory from superdeck_core’s Slide model, along with the corresponding tests, and documents the public API removal in the core changelog.

Changes:

  • Deleted Slide.error(...) from packages/core/lib/src/models/slide_model.dart.
  • Removed the Slide.error unit tests from packages/core/test/src/models/slide_model_test.dart.
  • Added a changelog entry noting the API removal and directing users to DeckErrorEvent for deck loading errors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/core/lib/src/models/slide_model.dart Removes the Slide.error(...) factory from the Slide public API.
packages/core/test/src/models/slide_model_test.dart Deletes tests that specifically exercised the removed factory.
packages/core/CHANGELOG.md Documents the API removal under ## Next and points to DeckErrorEvent.

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Visit the preview URL for this PR (updated for commit 091cc21):

https://superdeck-dev--pr55-leoafarias-remove-sl-tg44v2rd.web.app

(expires Fri, 10 Apr 2026 15:17:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bd68fc230762285849207e7e120aaf87cd4ca2f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants