refactor: remove Slide.error from core#55
Merged
leoafarias merged 2 commits intorelease/nextfrom Mar 11, 2026
Merged
Conversation
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
There was a problem hiding this comment.
Pull request overview
Removes the unused Slide.error(...) factory from superdeck_core’s Slide model, along with the corresponding tests, and documents the public API removal in the core changelog.
Changes:
- Deleted
Slide.error(...)frompackages/core/lib/src/models/slide_model.dart. - Removed the
Slide.errorunit tests frompackages/core/test/src/models/slide_model_test.dart. - Added a changelog entry noting the API removal and directing users to
DeckErrorEventfor deck loading errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/lib/src/models/slide_model.dart | Removes the Slide.error(...) factory from the Slide public API. |
| packages/core/test/src/models/slide_model_test.dart | Deletes tests that specifically exercised the removed factory. |
| packages/core/CHANGELOG.md | Documents the API removal under ## Next and points to DeckErrorEvent. |
|
Visit the preview URL for this PR (updated for commit 091cc21): https://superdeck-dev--pr55-leoafarias-remove-sl-tg44v2rd.web.app (expires Fri, 10 Apr 2026 15:17:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bd68fc230762285849207e7e120aaf87cd4ca2f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slide.error(...)factory fromsuperdeck_coreSlidemodel testspackages/core/CHANGELOG.mdValidation
cd packages/core && fvm exec dart test test/src/models/slide_model_test.dart test/src/models/block_model_test.dartcd packages/builder && fvm exec dart test test/src/parsers/section_parser_test.dart test/src/parsers/block_parser_test.dartrg -n "Slide\.error" /Users/leofarias/conductor/workspaces/superdeck/riyadh-v1