Repository navigation
feat(settings): listen ports in /api/settings - #450
Merged
Merged
Conversation
The setup help fills real ports instead of guessing from the page URL. Only listeners that are on are listed; an address without a fixed port is left out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /api/settingsgets aportsfield: the listen port of each listener that is on. The in-app setup help uses it to show real values instead of guessing from the page URL (behind a reverse proxy the page port is not the ingest port).http,smtp,monolog,var_dumper,proxy,xdebug,mcp.smtp/monolog/var_dumperonly when their module is on;xdebugonly when the Xdebug proxy is enabled;mcponly withtransport: http.:0, unparsable) is left out; the UI falls back to its defaults.Tests:
TestConfig_ListenPorts(table: defaults, xdebug/mcp on, mcp over socket, modules off, no fixed port),TestAPI_Settingschecks the field.