2026-04-01: Remove support for REv2.0 and REv2.1#202
Open
EdSchouten wants to merge 3 commits intomainfrom
Open
2026-04-01: Remove support for REv2.0 and REv2.1#202EdSchouten wants to merge 3 commits intomainfrom
EdSchouten wants to merge 3 commits intomainfrom
Conversation
|
On 2019-11-19, REv2 changed the way expected output paths are declared in the Command message. It used to be the case that files and directories were declared separately, but this prevents you from writing an action that captures either of those, depending on what the action generated. Given that this feature was added 6.5 years ago, let's go ahead and remove support for the old scheme. Clients have had more than enough time to implement the new scheme.
EdSchouten
force-pushed
the
eschouten/20260401-rev22
branch
from
fbba274 to
a964604
Compare
REv2.2 promoted the platform properties from the Command message to the Action message. This has the advantage that the scheduler no longer needs to process any Command messages. This saves one round trip to the CAS. Command messages can in some cases also become very large, meaning it adds unnecessary memory pressure on the scheduler. Given that this feature was added on 2020-10-17 and clients were able to adopt quickly. it's time to remove support for the old scheme.
With support for REv2.0 and REv2.1 specific features removed, we should go ahead and bump the deprecated API version to REv2.2. This will force clients to stop using these old features, or simply stop working altogether.
EdSchouten
force-pushed
the
eschouten/20260401-rev22
branch
from
a964604 to
00269f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the early days of REv2, we made some backward incompatible code changes:
Up until this point we provided support for both the old and new schemes. Support for the old schemes is gated by configuration options on the scheduler and worker. Given that the new schemes were added to the protocol on 2019-11-19 and 2020-10-17, I think it's time to go ahead and remove support for the old schemes. Maintainers of clients have had more than enough time to implement them.