Conversation
…o SDK-style Co-authored-by: bwinsley <64841770+bwinsley@users.noreply.github.com>
…lity Co-authored-by: bwinsley <64841770+bwinsley@users.noreply.github.com>
Co-authored-by: bwinsley <64841770+bwinsley@users.noreply.github.com>
Co-authored-by: bwinsley <64841770+bwinsley@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR claims to migrate JavaScript.Net from .NET Framework 4.7.2 to .NET 8, but the migration is incomplete. While the C# projects have been successfully converted to SDK-style .NET 8 projects, the core C++/CLI component has not been updated and still targets .NET Framework 4.7.2.
Key Issues:
- The C++/CLI project (JavaScript.Net.vcxproj) still has
TargetFrameworkVersionset tov4.7.2instead ofnet8.0 - The CLRSupport setting remains
trueinstead of the requiredNetCorevalue for .NET 8 - Documentation incorrectly claims the migration is complete
Completed Changes:
- C# test and demo projects successfully converted to SDK-style .NET 8 projects
- NuGet package versions updated (MSTest 3.1.1, FluentAssertions 6.12.0)
- FluentAssertions API calls updated to version 6.x syntax
- AppDomain test appropriately handled with conditional compilation
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| VALIDATION_REPORT.md | New validation report - incorrectly claims migration is complete |
| MIGRATION_TO_NET8.md | New migration guide - contains inaccurate information about C++/CLI changes |
| README.md | Updated build requirements - incorrectly states .NET 8 target |
| JavaScript.Net.vcxproj | Minor updates (WindowsTargetPlatformVersion, OutDir) - missing critical .NET 8 migration changes |
| Noesis.Javascript.Tests.csproj | Successfully converted to SDK-style .NET 8 project |
| Fiddling.csproj | Successfully converted to SDK-style .NET 8 project |
| JavaScript.Net.sln | Updated Visual Studio version (with formatting issue) |
| MultipleAppDomainsTest.cs | Added conditional compilation for .NET Core compatibility |
| Program.cs | Removed .NET Framework-specific using statement |
| Test files (multiple) | Updated FluentAssertions API calls to version 6.x syntax |
| app.config files | Deleted (appropriate for SDK-style projects) |
| packages.config | Deleted (replaced by PackageReference) |
| .gitignore | Updated .vs pattern to be more flexible |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ting a local handle
…ild and run tests
bwinsley
force-pushed
the
master
branch
2 times, most recently
from
d38fb6e to
1231fcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.