Improve dialog borders to better match light and dark themes#82
Open
Anas-Shakeel wants to merge 1 commit into
Open
Improve dialog borders to better match light and dark themes#82Anas-Shakeel wants to merge 1 commit into
Anas-Shakeel wants to merge 1 commit into
Conversation
Owner
|
Thank you! The few code lines look fine. But I still have to try it out before merging. This might take a few days. |
Author
No problem. Take your time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the styling of the dialogs such as Settings and About so that their borders better match the application's theme.
Previously, the dialogs used a prominent white border in dark mode and a black border in light mode, which stood out against the rest of the UI. This change replaces those with appropriate theme border colors, making the dialogs feel more consistent and less visually obtrusive.
Changes
Before vs After
Closes #81