Repository navigation
Add Cache.EarliestManagedExpiration - #413
Open
IslamElsayed wants to merge 1 commit into
Open
IslamElsayed wants to merge 1 commit into
IslamElsayed wants to merge 1 commit into
Conversation
Returns the earliest expiration among the managed certificates in the cache, for metrics such as the expiry gauge requested in caddyserver/caddy#1683.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small aggregate method on
Cachethat returns the earliest expiration among the managed certificates in the cache, andfalseif there are none. It's for the expiry gauge in caddyserver/caddy#1683, where @steadytao asked for it to come from CertMagic rather than be rebuilt from events.It walks the cache under the read lock, so it's meant for occasional callers such as a metrics scrape. It uses the package's own
expiresAt, and skips unmanaged certificates and any without a parsed leaf.TestEarliestManagedExpirationcovers an empty cache, a cache with only unmanaged certificates, and managed certificates with different expirations.(I used AI assistance, Claude, while preparing this; I reviewed and tested it myself.)