Repository navigation
Conversation
OpenSSL looks for that label on these bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEMEncodePrivateKey marshals an Ed25519 key with MarshalPKCS8PrivateKey and labels the block ED25519 PRIVATE KEY. PKCS#8 uses the PRIVATE KEY label. On this machine, LibreSSL pkey rejects the old label with "Expecting: ANY PRIVATE KEY" and reads the new label far enough to report the key type as Ed25519. This LibreSSL build has no Ed25519, so it does not print the key. The key bytes are unchanged.
PEMDecodePrivateKey already accepts both labels. An existing ED25519 PRIVATE KEY file still loads.
Fixes #391.