fix: CalDAV default calendar not written on booking#28445
Open
Harshithk951 wants to merge 2 commits intocalcom:mainfrom
Open
fix: CalDAV default calendar not written on booking#28445Harshithk951 wants to merge 2 commits intocalcom:mainfrom
Harshithk951 wants to merge 2 commits intocalcom:mainfrom
Conversation
Contributor
Author
|
@sahitya-chandra I don't have access to a CalDAV provider (e.g. GMX) to record a |
1dac870 to
7a38fb5
Compare
Member
sahitya-chandra
left a comment
There was a problem hiding this comment.
Can't approve this without video evidence...
Will you be able to provide it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When "Add to calendar" is set to "Default" in the CalDAV app, no calendar entry was created on booking even though confirmation emails were sent correctly.
Root cause: the filter in
BaseCalendarService.createEventfell through with: truewhen nodestinationCalendarexternalId was set, causingcreateCalendarObjectto fire against every discovered calendar collection. Servers like GMX silently drop these writes so no entry is ever created.Fix: replace
: truewithcalendars.slice(0, 1)— use only the first (primary) calendar when no explicit destination is configured. The explicit-calendar path is unchanged.Mandatory Tasks
How should this be tested?
Checklist