fix(auth): implement proper debounce ref for forgot password requests#28490
Open
javidan-io wants to merge 1 commit intocalcom:mainfrom
Open
fix(auth): implement proper debounce ref for forgot password requests#28490javidan-io wants to merge 1 commit intocalcom:mainfrom
javidan-io wants to merge 1 commit intocalcom:mainfrom
Conversation
|
javidan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in the
ForgotPasswordcomponent where the debounced submit function was being recreated on every React render. By moving thelodash.debouncewrapper into auseRef, we ensure the debounce timer properly persists across renders.Additionally, it removes an unnecessary
async/awaitfromhandleSubmitsincelodash.debouncedoes not return a Promise, preventing misleading execution flows.Visual Demo (For contributors especially)
N/A - This is a logic/performance fix with no visual changes to the UI.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
apps/web/modules/auth/forgot-password/forgot-password-view.tsxlocally and temporarily comment out theif (loading) { return; }check insidehandleSubmit./auth/forgot-password./api/auth/forgot-password, confirming the debounce is working correctly.loadingcheck afterwards!)Checklist