fix(embed): include calOrigin for non-default cloud domains#28498
Draft
abdulbaqui17 wants to merge 3 commits intocalcom:mainfrom
Draft
fix(embed): include calOrigin for non-default cloud domains#28498abdulbaqui17 wants to merge 3 commits intocalcom:mainfrom
abdulbaqui17 wants to merge 3 commits intocalcom:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calOriginfor non-default Cal cloud domains (for exampleapp.cal.eu)calOriginfor default cloud origins (https://app.cal.comandhttps://cal.com)Why
Published
@calcom/embed-reactdefaults toapp.cal.com. For users on non-default cloud domains likeapp.cal.eu, snippets generated withoutcalOrigincan resolve iframe URLs to the wrong TLD and return 404.Testing
TZ=UTC yarn vitest run packages/features/embed/lib/EmbedCodes.test.ts(run in local workspace where dependencies are already available)Fixes #28443
Summary by cubic
Fixes embed snippets to include
calOriginfor non-default cloud domains and preserves original duration in the reschedule flow. Also updates attendee emails to use the organizer’s time format when the attendee doesn’t have one set.calOriginfor non-default cloud origins (e.g., app.cal.eu); omit forhttps://app.cal.comandhttps://cal.com; handles trailing slashes; adds regression tests inpackages/features/embed/lib/EmbedCodes.test.ts.durationbased on the original booking length; keeps dynamic durations; adds tests for reschedule link and duration fallback.timeFormatinAttendeeScheduledEmailwhen attendee preference is missing; adds test coverage.Written for commit 90a1143. Summary will update on new commits.