fix(booker): show correct message when booking range hasn't opened yet

[abdulbaqui17]

Summary

• Detect when today is before a RANGE booking window's start date
• Show "Bookings open on {{date}}" instead of the misleading "Scheduling ended on {{date}}"
• Add no_availability_range_future i18n key
• Add regression test covering the pre-open state

Root Cause

NoAvailabilityDialog rendered the no_availability_range translation ("Scheduling ended on…") for both states of a RANGE period: before the window opens and after it closes. The component had no branch for the "not yet open" case.

Fix

In useDescription (inside NoAvailabilityDialog.tsx), check whether dayjs() is before periodStartDate. If so, use the new no_availability_range_future key that references the start date; otherwise fall through to the existing end-date message.

Validation

TZ=UTC yarn vitest run packages/features/calendars/__tests__/NoAvailabilityDialog.test.tsx
# 6/6 tests pass

Fixes #28470

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[cubic-dev-ai]

1 issue found across 8 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/features/calendars/components/NoAvailabilityDialog.tsx">

<violation number="1" location="packages/features/calendars/components/NoAvailabilityDialog.tsx:47">
P2: RANGE pre-open check uses local-time day boundaries, which can flip the message incorrectly across timezones.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: RANGE pre-open check uses local-time day boundaries, which can flip the message incorrectly across timezones.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/features/calendars/components/NoAvailabilityDialog.tsx, line 47:

<comment>RANGE pre-open check uses local-time day boundaries, which can flip the message incorrectly across timezones.</comment>

<file context>
@@ -42,6 +42,11 @@ const useDescription = (noFutureAvailability: boolean, p: PeriodData) => {
   if (p.periodType === "RANGE") {
+    // If the current date is before the range start, the booking window hasn't opened yet.
+    // Show an informative "opens on" message rather than the misleading "scheduling ended" copy.
+    if (p.periodStartDate && dayjs().isBefore(dayjs(p.periodStartDate).startOf("day"))) {
+      return t("no_availability_range_future", { date: dayjs(p.periodStartDate).format("MMMM D YYYY") });
+    }
</file context>

Suggested change

	if (p.periodStartDate && dayjs().isBefore(dayjs(p.periodStartDate).startOf("day"))) {
	if (p.periodStartDate && dayjs.utc().isBefore(dayjs.utc(p.periodStartDate).startOf("day"))) {

[Ryukemeister]

this is the same as #28495 gonna close this