Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-cats-float.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack": minor
---

Support Rspack 1.4 perfetto tracing method
25 changes: 25 additions & 0 deletions packages/repack/src/commands/rspack/profile/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { rspackVersion } from '@rspack/core';

function getRspackVersion() {
// get rid of `-beta`, `-rc` etc.
const version = rspackVersion.split('-')[0];
const [major, minor, patch] = version.split('.').map(Number);
return { major, minor, patch };
}

async function getProfilingHandler() {
const { major, minor } = getRspackVersion();
if (major > 1 || (major === 1 && minor >= 4)) {
return await import('./profile-1.4.js');
}
return await import('./profile-legacy.js');
}

export async function applyProfile(
filterValue: string,
traceLayer?: string,
traceOutput?: string
) {
const { applyProfile } = await getProfilingHandler();
return applyProfile(filterValue, traceLayer, traceOutput);
}
63 changes: 63 additions & 0 deletions packages/repack/src/commands/rspack/profile/profile-1.4.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/**
* Reference: https://github.com/web-infra-dev/rspack/blob/bdfe548f4e5fd09c1ccb4d43919426819fb9a34f/packages/rspack-cli/src/utils/profile.ts
*/

/**
* `RSPACK_PROFILE=ALL` // all trace events
* `RSPACK_PROFILE=OVERVIEW` // overview trace events
* `RSPACK_PROFILE=warn,tokio::net=info` // trace filter from https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#example-syntax
*/
import fs from 'node:fs';
import path from 'node:path';
import { rspack } from '@rspack/core';
const defaultRustTraceLayer = 'perfetto';

export async function applyProfile(
filterValue: string,
traceLayer: string = defaultRustTraceLayer,
traceOutput?: string
) {
const { asyncExitHook } = await import('exit-hook');

if (traceLayer !== 'logger' && traceLayer !== 'perfetto') {
throw new Error(`unsupported trace layer: ${traceLayer}`);
}
const timestamp = Date.now();
const defaultOutputDir = path.resolve(
`.rspack-profile-${timestamp}-${process.pid}`
);
if (!traceOutput) {
const defaultRustTracePerfettoOutput = path.resolve(
defaultOutputDir,
'rspack.pftrace'
);
const defaultRustTraceLoggerOutput = 'stdout';

const defaultTraceOutput =
traceLayer === 'perfetto'
? defaultRustTracePerfettoOutput
: defaultRustTraceLoggerOutput;

// biome-ignore lint/style/noParameterAssign: setting default value makes sense
traceOutput = defaultTraceOutput;
} else if (traceOutput !== 'stdout' && traceOutput !== 'stderr') {
// if traceOutput is not stdout or stderr, we need to ensure the directory exists
// biome-ignore lint/style/noParameterAssign: setting default value makes sense
traceOutput = path.resolve(defaultOutputDir, traceOutput);
}

await ensureFileDir(traceOutput);
await rspack.experiments.globalTrace.register(
filterValue,
traceLayer,
traceOutput
);
asyncExitHook(rspack.experiments.globalTrace.cleanup, {
wait: 500,
});
}

async function ensureFileDir(outputFilePath: string) {
const dir = path.dirname(outputFilePath);
await fs.promises.mkdir(dir, { recursive: true });
}
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export async function applyProfile(
await ensureFileDir(traceOutput);
await rspack.experiments.globalTrace.register(
filter,
// @ts-expect-error: chrome was dropped in favor of perfetto, needs fixing
// @ts-expect-error: legacy support for older versions of Rspack
traceLayer,
traceOutput
);
Expand Down
2 changes: 1 addition & 1 deletion packages/repack/src/commands/rspack/start.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export async function start(
}

if (process.env.RSPACK_PROFILE) {
const { applyProfile } = await import('./profile.js');
const { applyProfile } = await import('./profile/index.js');
await applyProfile(
process.env.RSPACK_PROFILE,
process.env.RSPACK_TRACE_LAYER,
Expand Down