chore: refresh ontology diagrams - #390
github-actions[bot] wants to merge 1 commit into
Conversation
c362b84 to
851aab7
Compare
bf5716f to
ddc5f96
Compare
5aefa7e to
94a949a
Compare
35ce429 to
ea0e349
Compare
ea0e349 to
45560f9
Compare
45560f9 to
ba5605f
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the ABox Mermaid diagram to include the AgentInstanceLoopIteration concept.
Changes:
- Added a new
AgentInstanceLoopIterationnode toontology/diagrams/abox.mmd.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| UserTask{UserTask} | ||
| Incident{Incident} | ||
| ProcessInstance{ProcessInstance} | ||
| AgentInstanceLoopIteration(AgentInstanceLoopIteration) |
ba5605f to
efe473d
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward, auto-generated diagram sync and the updated Mermaid syntax is consistent with the surrounding diagram structure.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
fd35568 to
655c370
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward sync of an auto-generated diagram artifact and is consistent with the surrounding Mermaid node definitions.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
655c370 to
9f776bd
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward auto-generated diagram refresh confined to ontology/diagrams/** with no functional code impact.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
9f776bd to
f73668a
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward auto-generated diagram refresh, with only a minor diagram-style consistency nit noted.
Review details
Suppressed comments (1)
ontology/diagrams/abox.mmd:17
- The new node uses a different Mermaid shape (
(...)) than the other runtime-ish nodes in this diagram ({...}forUserTask,Incident,ProcessInstance). If the intent is to keep these entity kinds visually consistent, switch this node to curly-brace syntax as well.
AgentInstanceLoopIteration(AgentInstanceLoopIteration)
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
f73668a to
2c366ab
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, auto-generated diagram sync that cleanly adds the missing entity kind without introducing code-path or behavioral risk.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
2c366ab to
27c72e0
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, syntax-valid Mermaid diagram refresh confined to ontology/diagrams/** and matches the stated auto-generated intent.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟡 Changes recommended
The generated ontology README and refresh workflow paths must be updated to prevent the ontology check from failing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
| UserTask{UserTask} | ||
| Incident{Incident} | ||
| ProcessInstance{ProcessInstance} | ||
| AgentInstanceLoopIteration(AgentInstanceLoopIteration) |
There was a problem hiding this comment.
🔵 Needs a closer look
Update the generated README block or workflow so the ontology check passes.
Review details
Suppressed comments (1)
ontology/diagrams/abox.mmd:17
- This addition leaves the generated ABox block in
ontology/README.mdstale: that block still ends atProcessInstance, sonpm run viz:ontology -- --checknow fails and the rendered README omits this entity. The refresh workflow currently limitsadd-pathstoontology/diagrams/**, so include the corresponding README update (or adjust the workflow to capture it) with this diagram.
AgentInstanceLoopIteration(AgentInstanceLoopIteration)
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
The stale README block causes the ontology visualization check to fail.
Review details
Suppressed comments (1)
ontology/diagrams/abox.mmd:17
- This adds the node to the committed diagram, but the generated ABox block in
ontology/README.mdis still missing it (lines 78–109). BecausesyncReadme()rewrites/checks that block againstontology/diagrams/abox.mmd,npm run viz:ontology -- --checknow fails and the rendered README remains stale. Please include the corresponding README regeneration and update the refresh workflow'sadd-pathsif it is meant to commit both generated surfaces.
AgentInstanceLoopIteration(AgentInstanceLoopIteration)
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
The diagram and README transclusion must be synchronized before approval.
Review details
Suppressed comments (1)
ontology/diagrams/abox.mmd:17
- This node makes
ontology/diagrams/abox.mmddiffer from the ABox Mermaid block embedded inontology/README.md(the README still ends atProcessInstance). Sincenpm run viz:ontology -- --checkvalidates that transclusion byte-for-byte, this refresh leaves the documented diagram stale and causes the check to fail; include the corresponding README update or adjust the workflow to commit all generated transclusion outputs.
AgentInstanceLoopIteration(AgentInstanceLoopIteration)
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
Auto-regenerated by .github/workflows/refresh-ontology-diagrams.yml after an ontology change merged to main (or as a nightly safety net).
Auto-generated by the
Refresh ontology diagramsworkflow.The committed
ontology/diagrams/*.mmdfiles drifted from whatthe emitter (
npm run viz:ontology) produces against thecurrent ABox/TBox. This PR brings them back in sync.
Diff is restricted to
ontology/diagrams/**. Safe to mergeonce CI is green.