Open
chore(ci): fail PR CI on breaking-change commit markers#388
Conversation
Agent-Logs-Url: https://github.com/camunda/c8ctl/sessions/91a421a3-d097-48c0-bbaf-51f6000026f7 Co-authored-by: jwulf <406975+jwulf@users.noreply.github.com>
Agent-Logs-Url: https://github.com/camunda/c8ctl/sessions/91a421a3-d097-48c0-bbaf-51f6000026f7 Co-authored-by: jwulf <406975+jwulf@users.noreply.github.com>
Agent-Logs-Url: https://github.com/camunda/c8ctl/sessions/91a421a3-d097-48c0-bbaf-51f6000026f7 Co-authored-by: jwulf <406975+jwulf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add breaking change commit detection to PR CI
chore(ci): fail PR CI on breaking-change commit markers
May 16, 2026
jwulf
marked this pull request as ready for review
May 29, 2026 05:01
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a PR-only CI guard that fails when any PR commit carries Conventional Commit breaking-change markers (type!: / type(scope)!: subjects or BREAKING CHANGE(S): footers), preventing accidental major semantic-release bumps. Also documents this guard in RELEASE.md.
Changes:
- New
breaking-change-commit-checkjob in.github/workflows/test.ymlthat walks${BASE_SHA}..${HEAD_SHA}and reports offending commits with a remediation message. RELEASE.mdnote explaining that PR CI now blocks breaking-change markers so authors can rewrite history before merging.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Adds the PR-only breaking-change commit scan job (uses actions/checkout@v6 with full history, bash regex over each commit's subject/body, fails with offending SHAs). |
| RELEASE.md | Adds one-line documentation of the new PR CI breaking-change marker check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit PR-time guard against unintended major semantic-release bumps. It detects breaking-change commit markers on incoming PR branches so maintainers can rewrite commit history before merging to
main.What changed
.github/workflows/test.yml:breaking-change-commit-check.${base}..${head}and fails when it finds:type!:/type(scope)!:)BREAKING CHANGE:/BREAKING CHANGES:footer markers in commit bodyDocs update
RELEASE.mdto document that PR CI now blocks breaking-change markers to prevent accidental major bumps from feature-branch-only commits.Workflow snippet