Ensure overlay mounts create required directories#6870
Open
Ndukiye wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Hi, just following up on this PR. I’d appreciate any feedback or review when someone from the maintainers has time. Happy to make any changes needed. |
holmanb
requested changes
Jun 12, 2026
Member
|
@Ndukiye Do you plan to continue working on this? |
Contributor
Author
|
@holmanb Yep! I addressed the feedback from your previous review by updating the documentation and pushed those changes a while ago. Since then I've just been waiting for another review. I'm happy to make any additional changes if you spot anything else. |
Member
|
Please address the failing CI jobs. |
…c-mounts-overlay-ensure-dirs
Remove trailing whitespace flagged by ruff (W293) and an unused fake_fs fixture parameter in test_overlay_dirs_are_created.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
fix(mounts): ensure overlay directories are created
Ensure required upper and work directories exist before overlay
mounts are applied. This prevents mount failures when directories
are missing during fstab processing.
Fixes #2916
LP: #1695277