Context
If we have docs PRs going stale, currently someone has to notice the merge conflicts, chase the author and in some cases not get any reply after. According to CONTRIBUTING.md a PR gets closed if review questions go unanswered for more than a week.
Proposal
1. Conflict detection and author notification
When a PR develops a conflict with main, label it and post a comment tagging the author about what happened and how to fix it.
2. Explicit PR state label
Two labels, applied automatically:
status/awaiting-author for anything waiting on the contributor (unanswered review question, unresolved conflict)status/awaiting-review for anything waiting on us
Everything below depends on this.
3. Stale PR closure
For PRs in awaiting-author:
- Warning comment at 7 business days
- Close at 10 business days (instead of immediately closing at the 7 day mark)
- Any author activity like push, comment, review etc resets the clock
- Closing comment says how to reopen: push a commit or leave a comment
- Exempt drafts, anything labeled blocked or on-hold, PRs from the docs team, and PRs where we have not assigned an SME yet
4. Reminders for reviewers
PRs sitting in awaiting-review past 7 days without any reviewers assigned get flagged and Devrel team gets pinged.
@Jatinp26 please add your feedback on this and anything else that can improve this workflow.
Context
If we have docs PRs going stale, currently someone has to notice the merge conflicts, chase the author and in some cases not get any reply after. According to CONTRIBUTING.md a PR gets closed if review questions go unanswered for more than a week.
Proposal
1. Conflict detection and author notification
When a PR develops a conflict with
main, label it and post a comment tagging the author about what happened and how to fix it.2. Explicit PR state label
Two labels, applied automatically:
status/awaiting-authorfor anything waiting on the contributor (unanswered review question, unresolved conflict)status/awaiting-reviewfor anything waiting on usEverything below depends on this.
3. Stale PR closure
For PRs in
awaiting-author:4. Reminders for reviewers
PRs sitting in
awaiting-reviewpast 7 days without any reviewers assigned get flagged and Devrel team gets pinged.@Jatinp26 please add your feedback on this and anything else that can improve this workflow.