Redo #2999 #3003
Closed
Redo #2999 #3003
+146
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiezhuzzz
force-pushed
the
feat/workdir-var
branch
2 times, most recently
from
64b78ed to
499d54e
Compare
jiezhuzzz
force-pushed
the
feat/workdir-var
branch
from
499d54e to
172e305
Compare
Owner
|
I don't think this will work in general, since the value of the working directory setting influences the behavior of backticks and calls to Or: I think this needs a more principled design, something like #2309. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR is broken by the pull bot. This new PR repeats the code and provide the variable functionality to
working-directory.