Repository navigation
WR498018 Fix grade performance - #119
Open
SimonThornett wants to merge 1 commit into
Open
SimonThornett wants to merge 1 commit into
SimonThornett wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
I've made the following changes in mod/subcourse/locallib.php:
New helper subcourse_get_gradeable_userids():
Grades are now loaded in one batch with grade_grade::fetch_users_grades(), instead of one query per user. How each grade is worked out hasn't changed.
Tests: I added test_subcourse_fetch_refgrades_requested_users to the existing tests/locallib_test.php. It covers passing a single user, users without the capability, the admin and guest users, invalid IDs, a user with no grade, and fetching everyone.