Upgrade Go to 1.25 and update vulnerable x/net and x/crypto dependencies - #163
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.25 in the Dockerfile and go.mod, upgrades several golang.org/x dependencies, and cleans up formatting in webhooks/cdap_webhook.go. All review comments have been filtered out as they pertain to version numbers, so there is no additional feedback to provide.
Contributor
Author
Done. |
riyaa14
force-pushed
the
fix/image-scanning-vulnerabilities
branch
2 times, most recently
from
July 8, 2026 05:53
e0c4187 to
6c5a965
Compare
riyaa14
force-pushed
the
fix/image-scanning-vulnerabilities
branch
from
July 8, 2026 06:01
6c5a965 to
3ce3c83
Compare
sidhdirenge
approved these changes
Jul 8, 2026
vsethi09
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update golang version and dependencies.
Testing
Unit tests: all passed (using
make test)Built and Deployed the image to K8 cluster and verified cdap-controller pod is running. Details:
1. Built and pushed the docker image to an artifact registry
2. Deployed the docker image on GKE cluster
Result - The pod was in running state.