Skip to content

Upgrade Go to 1.25 and update vulnerable x/net and x/crypto dependencies - #163

Merged
riyaa14 merged 1 commit into
developfrom
fix/image-scanning-vulnerabilities
Jul 9, 2026
Merged

Upgrade Go to 1.25 and update vulnerable x/net and x/crypto dependencies#163
riyaa14 merged 1 commit into
developfrom
fix/image-scanning-vulnerabilities

Conversation

@riyaa14

@riyaa14 riyaa14 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

update golang version and dependencies.

Testing

  1. Unit tests: all passed (using make test)

  2. Built and Deployed the image to K8 cluster and verified cdap-controller pod is running. Details:
    1. Built and pushed the docker image to an artifact registry
    2. Deployed the docker image on GKE cluster

Result - The pod was in running state.

@riyaa14 riyaa14 added the go Pull requests that update go code label Jun 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version to 1.25 in the Dockerfile and go.mod, upgrades several golang.org/x dependencies, and cleans up formatting in webhooks/cdap_webhook.go. All review comments have been filtered out as they pertain to version numbers, so there is no additional feedback to provide.

@riyaa14 riyaa14 changed the title Update GoLang version to fix image scanning vulnerabilities Upgrade Go to 1.25 and update vulnerable x/net and x/crypto dependencies Jun 18, 2026

@vsethi09 vsethi09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes to the golang package in vendor_old folder.

For reference see: #153

@riyaa14

riyaa14 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Please make changes to the golang package in vendor_old folder.

For reference see: #153

Done.

@riyaa14
riyaa14 force-pushed the fix/image-scanning-vulnerabilities branch 2 times, most recently from e0c4187 to 6c5a965 Compare July 8, 2026 05:53
@riyaa14
riyaa14 force-pushed the fix/image-scanning-vulnerabilities branch from 6c5a965 to 3ce3c83 Compare July 8, 2026 06:01
@riyaa14
riyaa14 requested a review from vsethi09 July 8, 2026 21:49
@riyaa14
riyaa14 removed the request for review from sahusanket July 9, 2026 13:42
@riyaa14
riyaa14 merged commit 840b9dd into develop Jul 9, 2026
11 checks passed
@riyaa14
riyaa14 deleted the fix/image-scanning-vulnerabilities branch July 9, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants