fix(evp): two bugs in this module that may lead to crash#73
Open
spacewander wants to merge 2 commits into
Open
fix(evp): two bugs in this module that may lead to crash#73spacewander wants to merge 2 commits into
spacewander wants to merge 2 commits into
Conversation
LuaJIT cdata values are always truthy, including null pointers. 'if not key then' silently skips the nil check when PEM_read_bio_RSAPrivateKey returns NULL for a malformed key, leading to EVP_PKEY_set1_RSA(evp_pkey, NULL) and a worker SIGSEGV. 'if key == nil' is the correct LuaJIT idiom for null cdata detection.
EVP_PKEY_get0_EC_KEY returns NULL when the EVP_PKEY holds a non-EC key (e.g., RSA). Passing NULL to EC_KEY_get0_group on the next line causes SIGSEGV. This is reachable via jwt:verify when a caller provides an RSA public key to verify a token whose header claims alg=ES256/ES384/ES512.
spacewander
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
feat— new feature or capabilityfix— bug fixchore— maintenance (deps, config, CI)docs— documentation onlyci— CI/workflow changesrefactor— code change that neither fixes a bug nor adds a featureChecklist
prove -r tvia the Docker testsuite image)