Skip to content

chore: add Biome code quality checks - #64

Closed
nihmadev wants to merge 4 commits into
cdmtn:mainfrom
nihmadev:chore/biome-code-quality
Closed

chore: add Biome code quality checks#64
nihmadev wants to merge 4 commits into
cdmtn:mainfrom
nihmadev:chore/biome-code-quality

Conversation

@nihmadev

Copy link
Copy Markdown

Description

Adds Biome as the shared formatter and linter so contributors use the same syntax rules regardless of their editor preferences.

The configuration standardizes indentation, line endings, quotes, semicolons, trailing commas, and line width. Generated output, vendored libraries, embedded runtimes, media assets, and package manager lockfiles are excluded from source checks.

The existing maintained JavaScript, TypeScript, CSS, and JSON files are formatted once in this PR. This accounts for most of the diff and establishes a clean baseline for future contributions.

CI

Adds a Code Quality workflow for pull requests and pushes to the main branches. Pull requests check files changed from the base commit and publish diagnostics as GitHub annotations. Pushes to main run the same checks across the repository.

Contributor commands are documented in the README. Use npm run check to verify changes and npm run check:fix to apply safe fixes.

Verified with Biome 2.5.6 using the full repository check, formatter check, and changed files check.

@NotKiwy

NotKiwy commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

lgtm

@NotKiwy NotKiwy added the reviewed Triage member reviewed this PR label Jul 28, 2026
@NotKiwy
NotKiwy requested a review from cdmtn-dev July 28, 2026 14:49
@cdmtn-dev cdmtn-dev added blocked / suspicious PR has been blocked due to suspicions and removed reviewed Triage member reviewed this PR labels Jul 28, 2026

@cdmtn-dev cdmtn-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conf

nihmadev and others added 3 commits July 28, 2026 21:37
Resolve conflicts by accepting upstream functionality (GitHub forking,
GitHub token settings, addToBug crash fix, isPackaged/localJson path fix,
smoothScroll removal) and applying Biome formatting to all merged code.
Accept upstream's gitignore module extraction and apply Biome formatting.
@cdmtn-dev cdmtn-dev added enhancement New feature or request and removed blocked / suspicious PR has been blocked due to suspicions labels Jul 28, 2026

@cdmtn-dev cdmtn-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, I'm not ready to implement major style changes. They conflict with the current development, and after testing, I ran into problems during the build.

@cdmtn-dev cdmtn-dev closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants