Open
Conversation
rootulp
approved these changes
Apr 29, 2026
Collaborator
rootulp
left a comment
There was a problem hiding this comment.
It may be confusing to call v8 Hibiscus because v7 was Hibiscus. I'm not opinionated on the upgrade names and internally refer to them as v7 and v8 to avoid confusion.
Member
Author
|
should we make a new CIP for v8? and call it v8, and Hibiscus (v7) just "skips" mainnet? |
Collaborator
|
That works too and seems slightly preferable. |
Member
Author
|
agreed. i think maybe it would be best to edit v7 hibiscus to only include what was actually in v7. i'll need to think on this a bit more and make a FLUP with the "real" v8 |
Collaborator
|
v7 included all those CIPs, we just prevented it from shipping to Mainnet because the x/forwarding bug. v8 also includes all those CIPs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x/forwardingbug was discovered during testnet rollout.Validation
npx markdownlint-cli@0.39.0 --config .markdownlint.yaml cips/cip-044.md cips/cip-045.md cips/cip-046.md cips/cip-047.md cips/cip-049.md cips/README.md cips/SUMMARY.mdnpx markdownlint-cli@0.39.0 --config .markdownlint.yaml cips/cip-049.md cips/README.md cips/SUMMARY.mdgit diff --check