Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5361 +/- ##
==========================================
- Coverage 38.77% 38.75% -0.02%
==========================================
Files 323 323
Lines 22459 22459
==========================================
- Hits 8708 8704 -4
- Misses 12706 12708 +2
- Partials 1045 1047 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
[High impact] No blocking issue is identified. Replacing the preview dependency pins remains a documented prerequisite for releasing node, rather than an unresolved merge blocker.
|
Resolve the proofs_cache_test.go import conflict using the celestia-app/rsmt2d path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BcmovctaELpQeE3EMTd6fe
Migrate node's rsmt2d imports, generated mocks and nested tastora module to the independent library in celestia-app #8312. Pin app at the migration-only v10.4.0 backport #8314 simultaneously so exported EDS/tree types use the same Go import path.
The backport preserves node's current app API, Fibre defaults and dependency versions. Current app v10.x is deliberately not used: it contains additional Fibre interface/default changes. Outside the new rsmt2d path and app commit, dependency versions are unchanged in both modules.
Preview module/app commits are real and resolvable. Replace both pseudo-versions with the corresponding published releases before releasing node; maintainer selection of the app v10.4 release branch is pending. No release or tag is created here.
Validation: all root packages compile (
go test -run '^$' ./...); EDS, shwap, IPLD, header and store suites pass; both module manifests tidied; changed imports checked with the repository's goimports-reviser configuration. The rsmt2d library's repeated race tests and old/new root/repair/JSON parity checks also pass. Nested tastora manifests were tidied, but its Docker integration suite was not run.Review level: [high] — app and node exchange exported EDS types across a Go module identity change. Draft pending coordinated app/library releases and CI.
CI note: the Go Mod Parity Check reports two pre-existing mismatches (Azure/go-ansiterm and docker/go-connections). Complete module lists generated from untouched baseline
55a5be2reproduce exactly the same two mismatches; neither dependency declaration changes here. Root/tastora tidy and import lint pass. This unrelated baseline CI failure remains visible rather than adding dependency upgrades to the migration.Final CI snapshot: Linux and macOS unit tests, coverage, golangci-lint, import lint, tidy and OpenRPC generation all pass. Only the baseline parity mismatch above fails; Docker-based integration tests were skipped.