fix: unlock dates ignore leap years#72
Merged
Merged
Conversation
Vesting accounts unlock N * 365 days after TGE, not N calendar years, because vesting account end times do not account for the leap day on February 29th, 2024. Verified against vesting account end times in the mainnet genesis file: delayed vesting accounts end October 30th, 2024 and continuous vesting accounts end October 30th, 2025 or 2026. Closes #35 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rach-id
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #35
Vesting accounts unlock N * 365 days after TGE, not N calendar years, because vesting account end times do not account for the leap day on February 29th, 2024. Verified against the vesting accounts in the mainnet genesis file:
Changes
twoYearsAfterTGE,threeYearsAfterTGE, andfourYearsAfterTGEas N * 365 days after TGE and resolve the TODO from fix: year one unlock date #34.TestUnlockDatesto pin all four unlock dates to October 30th.🤖 Generated with Claude Code