Draft
Conversation
Signed-off-by: Maël Valais <mael@vls.dev>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Member
|
This PR title is wrong I think. |
Member
Author
|
Oops, I think I mixed two of my PRs. Thanks for spotting that! |
Contributor
|
@maelvls: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new command
cmrel update-release-branch, and the goal is to automate this part of our release-process.The
cmrel update-release-branch --branch release-1.4does the following:release-1.4does not exist, create it,release-1.4already exists,merge --ff-only masterand push it.Note that
cmrel update-release-branchcurrently does not know about the "code freeze":cmrel update-release-branchmust not be run during a code freeze, since merged PRs myst be cherry picked during that period.The part of release process in question: