Repository navigation
docs: fix broken ServiceAccount anchor and several typos - #2306
avneetbansal-aws wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
The route53 DNS01 docs and the AWS getting-started tutorial linked to #referencing-your-own-serviceaccount-within-in-an-issuer-or-clusterissuer, which is not a heading in route53.md; the section is IAM Role with dedicated Kubernetes ServiceAccount (#iam-role-with-dedicated-kubernetes-serviceaccount), the slug the tutorial already uses elsewhere. Also fixes doubled-word/article typos in faq, ingress, rfc2136, acme-dns, best-practice, and the venafi tutorial. Signed-off-by: avneetbansal-aws <284363899+avneetbansal-aws@users.noreply.github.com>
b829f73 to
3a7d057
Compare
|
Friendly nudge. This PR fixes a broken ServiceAccount anchor in the Route53 docs and the AWS tutorial, plus a few doubled-word typos, and I have just rebased it onto the current master. The dco check and the Netlify deploy preview pass, and tide is pending only because the PR still needs review. @wallrj, as suggested by the bot, could you take a look and approve when you have time? |
Small docs fixes I came across while reading through the DNS01 and getting-started docs.
The main one: the Route53 DNS01 page and the AWS getting-started tutorial both link to
route53.md#referencing-your-own-serviceaccount-within-in-an-issuer-or-clusterissuer, which isn't a heading that exists (note the "within-in"). The section they mean is "IAM Role with dedicated Kubernetes ServiceAccount", slug#iam-role-with-dedicated-kubernetes-serviceaccount— which is the slug the same tutorial already uses further down, so both links now point to the same place.The rest are doubled-word / article typos in prose: "the the spec" (faq), "refer to to" (ingress), "a the TXT RR" (rfc2136), "and and" (acme-dns), "the the cert-manager webhook" (best-practice), and "can can be provisioned" (venafi tutorial).
Docs only, no content changes.