Skip to content

docs: fix broken ServiceAccount anchor and several typos - #2306

Open
avneetbansal-aws wants to merge 1 commit into
cert-manager:masterfrom
avneetbansal-aws:docs/fix-broken-anchor-and-typos
Open

avneetbansal-aws wants to merge 1 commit into
cert-manager:masterfrom
avneetbansal-aws:docs/fix-broken-anchor-and-typos

Conversation

@avneetbansal-aws

Copy link
Copy Markdown

Small docs fixes I came across while reading through the DNS01 and getting-started docs.

The main one: the Route53 DNS01 page and the AWS getting-started tutorial both link to route53.md#referencing-your-own-serviceaccount-within-in-an-issuer-or-clusterissuer, which isn't a heading that exists (note the "within-in"). The section they mean is "IAM Role with dedicated Kubernetes ServiceAccount", slug #iam-role-with-dedicated-kubernetes-serviceaccount — which is the slug the same tutorial already uses further down, so both links now point to the same place.

The rest are doubled-word / article typos in prose: "the the spec" (faq), "refer to to" (ingress), "a the TXT RR" (rfc2136), "and and" (acme-dns), "the the cert-manager webhook" (best-practice), and "can can be provisioned" (venafi tutorial).

Docs only, no content changes.

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Sep 28, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wallrj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 28, 2026
@netlify

netlify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a7d057
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/6b01fc409d18c46dfa7fd4a7
😎 Deploy Preview https://deploy-preview-2306--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

The route53 DNS01 docs and the AWS getting-started tutorial linked to #referencing-your-own-serviceaccount-within-in-an-issuer-or-clusterissuer, which is not a heading in route53.md; the section is IAM Role with dedicated Kubernetes ServiceAccount (#iam-role-with-dedicated-kubernetes-serviceaccount), the slug the tutorial already uses elsewhere. Also fixes doubled-word/article typos in faq, ingress, rfc2136, acme-dns, best-practice, and the venafi tutorial.

Signed-off-by: avneetbansal-aws <284363899+avneetbansal-aws@users.noreply.github.com>
@avneetbansal-aws
avneetbansal-aws force-pushed the docs/fix-broken-anchor-and-typos branch from b829f73 to 3a7d057 Compare November 21, 2026 20:17
@avneetbansal-aws

Copy link
Copy Markdown
Author

Friendly nudge. This PR fixes a broken ServiceAccount anchor in the Route53 docs and the AWS tutorial, plus a few doubled-word typos, and I have just rebased it onto the current master. The dco check and the Netlify deploy preview pass, and tide is pending only because the PR still needs review. @wallrj, as suggested by the bot, could you take a look and approve when you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant