Closed
Conversation
|
I'm not sure that Docker is a right tool for this. Python already comes with its own containerizing tools for virtual environments (mostly for the custom dependencies), which are ideal for a one-time runtime. Docker on the other hand is perfect for continuous service (like a server). This tool is not a server that runs indefinitely, it's merely just a command line tool that runs once and then gracefully exits back to the shell. Nothing else. Docker is a wrong tool for virtual environment in this case. |
Owner
|
I agree with @Polda18. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerize the tool, add CI so that people can just run it straight off ghcr.io