fix(overlaps): scan only query-range boundary points (#127) - #158
Open
IMGillusion wants to merge 1 commit into
Open
IMGillusion wants to merge 1 commit into
IMGillusion wants to merge 1 commit into
Conversation
overlaps_range() tested every boundary point in the tree (O(n) pure-python comparisons per query) instead of just the points inside (begin, end). Restrict the scan to the bisect slice, mirroring the indexing overlap() already uses. Unfixed: ~4s for 200 queries on a 300k-interval tree; fixed: ~0.01s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overlaps(begin, end) on a range tested every boundary point in the tree
(O(n) pure-python comparisons per query) instead of just the points
inside (begin, end). This is the 15-minutes-vs-12-seconds gap reported in
#127 (450k-interval tree, profile pointed at the overlaps_range genexpr).
The scan is now restricted to the bisect slice [begin, end), mirroring the
indexing
overlap()already uses in the same file. Semantics areunchanged: boundaries exactly at
beginwere already covered by thepreceding
overlaps_point(begin)check, and the previous strictbegin < bound < endfilter excluded exactly the points the bisectbounds exclude.
Benchmark (300k disjoint intervals, 600k boundary points, 200 miss-case queries)
New regression test
test/issues/issue127_test.pypins both the semantics(gap -> False, touching interval -> True) and the scaling.
Full suite: 105 passed, no regressions.