Drop compat bounds that can never resolve - #115
Merged
Merged
Conversation
MCMCChains caps StatsFuns below 2, and StatsFuns below 2 caps LogExpFunctions below 1, so allowing LogExpFunctions 1 and StatsFuns 2 was wrong. Normal resolution picked the satisfiable versions and hid it, but julia-runtest turns on force_latest_compatible_version for Dependabot PRs, which exposed it.
Contributor
|
NestedSamplers.jl documentation for PR #115 is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the test failures on #113.
julia-runtestturns onforce_latest_compatible_versionfor Dependabot PRs, so it tries to install the newest version each compat entry claims to allow. Two of the bounds added in #111 cannot be reached: MCMCChains caps StatsFuns below 2, and StatsFuns below 2 caps LogExpFunctions below 1. Ordinary resolution quietly picked the satisfiable versions, which is why #111 and #112 were green, but forcing the latest makes it unsatisfiable.So
LogExpFunctionsgoes back to"0.3"and the test env'sStatsFunsto"0.9, 1", and the changelog no longer claims LogExpFunctions 1 works.Also adds a
[compat]block todocs/Project.tomlat versions that actually resolve together. #113 tried to add one, but picked the latest of each package independently without solving them jointly, which is why its docs job failed too.Verified locally with
Pkg.test(; force_latest_compatible_version=true), the same mode CI uses on Dependabot PRs, plus a clean resolve of the docs environment.