AC Power Board: Improve LED handling#27
Open
lategoodbye wants to merge 3 commits into
Open
Conversation
Current config wasn't prepared for AC Power Board, which has 4 individual LEDs (red, green, blue, white) driven by NXP PCA9632. - Enable LEDS_GROUP_MULTICOLOR to group all 4 individual LEDs to a RGBW one - Make LEDS_CLASS_MULTICOLOR and LEDS_PCA963X built-in for sooner LED handling during boot - Enable LEDS_TRIGGER_PATTERN for RGB fading effects Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
Before this change the driver initialized all LEDs with maximum intensity. This isn't useful for LEDs, which needs to be configured via DT. So introduce a new DT property to define the default intensity of all indiviual LEDs. In case something went wrong the driver fallsback to maximum brightness. Additionally this also works with triggers. So it should be possible to blink with a specific RGB color. This has been tested with Tarragon board. Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
This groups all 4 individual LEDs to an additional RGBW LED (rgb:status). Be aware that the sysfs of the individual LEDs become read-only. Additionally the LEDs will now blink white during boot. Unfortunately this can only be tested with real hardware. Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improve the LED support on AC Power Board. The main goal is to make the LEDs blink white during boot, but it contains some further improvements.