Call super().__init__() in PoolScheduler __init__#216
Open
nchristensen wants to merge 1 commit intocharmplusplus:mainfrom
Open
Call super().__init__() in PoolScheduler __init__#216nchristensen wants to merge 1 commit intocharmplusplus:mainfrom
nchristensen wants to merge 1 commit intocharmplusplus:mainfrom
Conversation
Subclasses of `PoolScheduler` can't work with the Pool because a missing attribute `__local_free_head` causes `__addLocal__` to raise an AttributeError. Calling `super().__init__()` in the `PoolScheduler` `__init__` method seems to fix this since the `Chare` class sets this attribute in its `__init__()`.
|
This pull request fixes 1 alert when merging 84083a0 into 3603cae - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subclasses of
PoolSchedulercan't work with thePoolbecause a missing attribute__local_free_headcauses__addLocal__to raise an AttributeError. Callingsuper().__init__()in thePoolScheduler__init__method seems to fix this since theChareclass sets this attribute in its__init__().