Add concurrent.futures.Executor implementation#235
Add concurrent.futures.Executor implementation#235nchristensen wants to merge 19 commits intocharmplusplus:mainfrom
Conversation
|
This pull request introduces 2 alerts when merging 1b08833 into 74791f9 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request introduces 2 alerts when merging 08cf569 into 74791f9 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
Hi Nick, |
|
Cool, that would be great! It could definitely use another pair of eyes. |
|
This pull request fixes 1 alert when merging 9822860 into 74791f9 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request fixes 1 alert when merging 282a11b into 74791f9 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request fixes 1 alert when merging b71e4b3 into 74791f9 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request introduces 7 alerts and fixes 2 when merging 081d3dc into 74791f9 - view on LGTM.com new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
This pull request introduces 7 alerts and fixes 2 when merging 2bbb9a8 into 74791f9 - view on LGTM.com new alerts:
fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This adds a concurrent.futures.Executor implementation for Charm4py so Charm4py can be dropped in wherever
ThreadPoolExecutor,ProcessPoolExecutor,MPI4pyPoolExecutor, etc. is used.A
PoolExecutorclass inpool.pyimplements theExecutorAPI by calling to equivalentPoolmethods. This pull request also makescharm4py.threads.Futureinherit fromconcurrent.futures.Futureand implements its API.TODO:
Future.set_running_or_notify_cancel()and figure out where to call it. Execution currently hangs without explicitly callingFuture.get().