feat(toolchain): list installed toolchains in release order by chawyehsu · Pull Request #206 · chawyehsu/moonup

chawyehsu · 2026-08-10T12:44:37Z

before:

Installed toolchains:
  0.10.3+16975d007
  0.10.6+80dc50f24
  0.6.22
  0.6.24+012953835
  0.6.29+9037370fc
  0.9.2+bbe2b338f
  0.9.3+08f337e2c
  latest (0.10.6+80dc50f24)
  nightly-2026-08-08
  nightly (2026-07-28)

after

Installed toolchains:
  nightly-2026-08-08
  0.6.22
  0.6.24+012953835
  0.6.29+9037370fc
  0.9.2+bbe2b338f
  0.9.3+08f337e2c
  0.10.3+16975d007
  0.10.6+80dc50f24
  nightly (2026-07-28)
  latest (0.10.6+80dc50f24)

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>

coderabbitai · 2026-08-10T12:46:33Z

Warning

Review limit reached

@chawyehsu, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2924f972-9a5c-4f0e-9445-66ee558af45d

📥 Commits

Reviewing files that changed from the base of the PR and between 885b200 and e9aa7f4.

📒 Files selected for processing (1)

src/toolchain/mod.rs

Summary by CodeRabbit

New Features
- Toolchains are now displayed in release order: versioned toolchains by channel and release date, followed by bleeding, nightly, and latest.
- Latest releases use cached channel information when available, with numeric version ordering as a fallback.
- Nightly toolchains are ordered by release date.
- Ordering remains reliable when cached release information is unavailable or outdated.
Documentation
- Added documentation defining the toolchain release-ordering rules.

Walkthrough

The change defines release-order terminology and replaces direct toolchain ordering with channel-, date-, cached-index-, and numeric-version-based sorting. Cached index failures use numeric fallback ordering.

Changes

Release ordering

Layer / File(s)	Summary
Release order helpers `CONTEXT.md`, `src/toolchain/mod.rs`	Defines ordering for `bleeding`, `nightly`, and `latest`, including nightly dates, cached latest positions, numeric versions, and build-metadata removal.
Sorting and cached index integration `src/toolchain/mod.rs`, `tests/integration/atomic.rs`	Sorts installed toolchains with release-order keys. Loads `channel-latest.json` when available and uses numeric fallback ordering when loading or parsing fails. The integration test covers a stale cache that omits an installed version.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ae59510-3ab4-4a04-83db-80b101c0585b

📥 Commits

Reviewing files that changed from the base of the PR and between 97c6c4f and af2468e.

📒 Files selected for processing (2)

CONTEXT.md
src/toolchain/mod.rs

coderabbitai · 2026-08-10T12:46:36Z

+    fn parse(version: &str) -> Self {
+        // ignore the `+build` metadata suffix (e.g. `0.10.6+80dc50f24`)
+        let core = version.split('+').next().unwrap_or(version);
+        let parts = core
+            .split('.')
+            .map(|p| p.parse::<u64>().unwrap_or(0))
+            .collect();


🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Normalize the optional v prefix before parsing numeric components.

CONTEXT.md defines v1.0.0 as a valid toolchain spec. NumericVersion::parse("v1.0.0") parses the first component as 0. As a result, v1.0.0 and v2.0.0 can compare equal during numeric fallback sorting.

Strip one leading v before splitting the version. Add fallback-order tests for v0.x, v1.x, and v2.x.

@coderabbitai addressed in https://github.com/chawyehsu/moonup/pull/200/changes#diff-86fee53c33308768d49a4ac0ff5720fd7f5411a8c8bd62ab9b80bbffa2977a14R12

@chawyehsu, thank you. Pull request #206 does not yet include that change.

NumericVersion::parse still does not remove a leading v before parsing. Please incorporate the fix from #200 into this pull request, or close this review thread after the change reaches this branch.

_{You are interacting with an AI system.}

codecov · 2026-08-10T12:47:43Z

Codecov Report

❌ Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.56%. Comparing base (97c6c4f) to head (885b200).

Files with missing lines	Patch %	Lines
src/toolchain/mod.rs	87.75%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   87.11%   88.56%   +1.44%     
==========================================
  Files          25       25              
  Lines        1677     1697      +20     
==========================================
+ Hits         1461     1503      +42     
+ Misses        216      194      -22

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>

Copilot

Pull request overview

This PR changes how moonup list (and other callers of installed_toolchains()) order installed toolchains so they’re displayed in release order rather than lexicographic/alphabetical name order.

Changes:

Replace ToolchainSpec’s custom ordering with an explicit “release order” sort key used when listing installed toolchains.
Order versioned installs by channel and release chronology (nightly builds by date; stable/latest releases by cached channel-latest.json ordering, with numeric fallback).
Document the “release order” term in CONTEXT.md and add an integration test for stale latest-cache fallback behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/integration/atomic.rs	Adds coverage ensuring stale `channel-latest.json` does not mis-order installed numeric versions.
src/toolchain/mod.rs	Implements release-order sorting for installed toolchains, including cached-index positioning and numeric fallback.
CONTEXT.md	Defines “Release order” to standardize terminology in the repo.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>

feat(toolchain): list installed toolchains in release order

af2468e

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>

coderabbitai Bot reviewed Aug 10, 2026

View reviewed changes

fix(toolchain): fall back to numeric ordering when latest cache is stale

8297ebf

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>

chawyehsu requested a lite review from Copilot August 10, 2026 12:55

Copilot started reviewing on behalf of chawyehsu August 10, 2026 12:56 View session

Copilot AI reviewed Aug 10, 2026

View reviewed changes

Comment thread src/toolchain/mod.rs Outdated

chawyehsu added 2 commits August 10, 2026 21:53

perf: sort by release order using sort_by_key

885b200

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>

docs(toolchain): clarify Latest variant fallback ordering [ci skip]

e9aa7f4

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>

chawyehsu merged commit b490f16 into main Aug 10, 2026

release-maid Bot mentioned this pull request Aug 10, 2026

chore(main): release 0.6.0 #198

Merged

Navigation Menu

Uh oh!

feat(toolchain): list installed toolchains in release order - #206

feat(toolchain): list installed toolchains in release order#206
chawyehsu merged 4 commits into
mainfrom
push-yoyknpmyrrup

chawyehsu commented Aug 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

Review limit reached

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot Aug 10, 2026 •

edited

Loading

Uh oh!

chawyehsu Aug 10, 2026

Uh oh!

coderabbitai Bot Aug 10, 2026

Uh oh!

codecov Bot commented Aug 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

chawyehsu commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chawyehsu Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chawyehsu commented Aug 10, 2026 •

edited

Loading

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

coderabbitai Bot Aug 10, 2026 •

edited

Loading

codecov Bot commented Aug 10, 2026 •

edited

Loading