Phase 1: Protocol consolidation (FileRead/FileWrite options + wire error visibility) - #300
Open
chipsenkbeil wants to merge 10 commits into
Open
Phase 1: Protocol consolidation (FileRead/FileWrite options + wire error visibility)#300chipsenkbeil wants to merge 10 commits into
chipsenkbeil wants to merge 10 commits into
Conversation
Design spec for decomposing the feature/file-mount branch into 8 phased PRs. Covers protocol consolidation, network resilience, event system, mount lifecycle, distant-mount crate, CLI, and 4 mount backends (NFS, FUSE, FileProvider, Cloud Files). Includes AI dev process guardrails and test reliability strategy.
…pend Update all Api trait implementations (host, ssh, docker) and callsites to use the new 2-method file API (read_file with ReadFileOptions, write_file with WriteFileOptions) instead of the previous 6-method API. Host backend: full offset/len/append support with fast paths for default options. SSH/Docker backends: stub updates to match trait signatures.
Pre-existing lint caught by newer clippy (1.95.0) on CI. Three match arms in SSH config parsing had if-conditions that should be match guards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of
Phase 1 of the file-mount branch decomposition. See docs/superpowers/specs/2026-04-16-file-mount-decomposition-design.md
Test plan
#[serde(default)])