Add asio::basic_errors::not_supported#1736
Open
Lkzeu wants to merge 1 commit intochriskohlhoff:masterfrom
Open
Add asio::basic_errors::not_supported#1736Lkzeu wants to merge 1 commit intochriskohlhoff:masterfrom
Lkzeu wants to merge 1 commit intochriskohlhoff:masterfrom
Conversation
As noted by Vinícius dos Santos¹, ENOTSUP and EOPNOTSUPP may alias on some systems. That's the case for Linux and FreeBSD. On Systems where ENOTSUP and EOPNOTSUPP have the same errno values, one might inadvertently catch EOPNOTSUPP when a composed operation throws ENOTSUP. There's nothing ASIO can do here, so we don't try to. Reference: ¹https://sourceforge.net/p/asio/mailman/message/58710157/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted by Vinícius dos Santos¹, ENOTSUP and EOPNOTSUPP may alias on some systems. That's the case for Linux and FreeBSD.
On Systems where ENOTSUP and EOPNOTSUPP have the same errno values, one might inadvertently catch EOPNOTSUPP when a composed operation throws ENOTSUP. There's nothing ASIO can do here, so we don't try to.
Reference:
¹https://sourceforge.net/p/asio/mailman/message/58710157/