fix: file drop overlay staying active when drag leaves the drop zone - #3023
Open
Vladexy88x wants to merge 3 commits into
Open
fix: file drop overlay staying active when drag leaves the drop zone#3023Vladexy88x wants to merge 3 commits into
Vladexy88x wants to merge 3 commits into
Conversation
Replace the drag-state ref tracking with a relatedTarget check in dragleave, so the overlay deactivates when the pointer leaves the zone or the window. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Vladexy88x
changed the title
|
Thank you! |
Replace the unchecked `as Node | null` downcast with an `instanceof Node` check so a non-Node EventTarget cannot make `contains()` throw inside the listener and strand the overlay active. Also document the two things the guard silently depends on: relatedTarget is absent on drag-cancel and on every WebKit dragleave, not just when leaving the window; and portaled Overlays/PopOuts are never contained by the zone, so the drop overlay's pointerEvents: 'none' is load-bearing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #2555
The file drop overlay (
useFileDropZone) could stay active after the dragged file left the drop zone or the window, because the previous implementation tracked drag state in a ref and only deactivated ondragleavewhen the last state wasover.This PR replaces the ref-based state tracking with a
relatedTargetcheck in thedragleavehandler: the overlay is deactivated when the element being entered is outside the zone, ornull(pointer left the window). This also lets us drop thedragStateRefand the bookkeeping in thedrop/dragoverhandlers.in collaboration Claude Code