fix: emoji autocompletion overwriting preceding element - #3064
Merged
Conversation
this prevents the range from encroaching on the node of elements like emojis and pings to prevent them from being overwritten
Contributor
Author
|
I thought a bot was supposed to comment to let me sign the CLA? |
Member
|
@wjaaaaaaat Can you do a dummy commit or something to trigger the check again. None of the checks are triggered on you PR. |
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Aug 10, 2026
|
Preview: https://3064--cinny-pr.netlify.app |
kfiven
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3063. Also fixes a couple typos of "word" as "world".
The function
getPrevWordRange(formerly known asgetPrevWorldRange) would include the empty text children of elements like emojis, causing such elements to be deleted if they immediately preceded autocompletions.It now stops if it detects a
char === ''which indicates that it has encountered an empty text node. This allows emojis to be created next to each other without error.