Repository navigation
improve loop detection - #1069
Merged
Merged
Conversation
Generalize the recognized pattern from ``` (letrec ([f (lambda ....)]) (f arg ...)) ``` to allow a loop entry into `f` to be anywhere in the `letrec` body as long as there's a single call to `f` as an entry point (and `f` is otherwise only tail-called within the `lambda` body). Also, avoid merging `letrec`s in the cpletrec pass, which can otherwise obscure loops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize the recognized pattern from
to allow a loop entry into
fto be anywhere in theletrecbody as long as there's a single call tofas an entry point (andfis otherwise only tail-called within thelambdabody). Also, avoid mergingletrecs in the cpletrec pass, which can otherwise obscure loops.Loops conversion by itself doesn't help all that much, since function calls are already fast. But loop conversion can enable floating-point unboxing, which can offer substantial performance benefits.