Skip to content

feat(memory): make local record capacity configurable - #155

Draft
patrick-ogrady wants to merge 3 commits into
mainfrom
memory-capacity
Draft

feat(memory): make local record capacity configurable#155
patrick-ogrady wants to merge 3 commits into
mainfrom
memory-capacity

Conversation

@patrick-ogrady

@patrick-ogrady patrick-ogrady commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a positive memory.max_records setting for local memory while preserving the 512-record default
  • derive local aggregate-content capacity from the record count and fixed 1 KiB per-record limit
  • apply the configured count to runtime storage and push/pull snapshots while leaving remote capacity service-owned

@patrick-ogrady
patrick-ogrady requested a review from clabby August 16, 2026 15:45
Comment thread bin/tact/src/app/config.rs Outdated
pub(crate) struct MemoryConfig {
enabled: bool,
max_records: usize,
max_total_content_bytes: usize,

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given records already have a capped size, I think you could just limit by max_records.

@codspeed-hq

codspeed-hq Bot commented Aug 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 18 untouched benchmarks
⏩ 31 skipped benchmarks1


Comparing memory-capacity (1357f73) with main (ee5b1ca)

Open in CodSpeed

Footnotes

  1. 31 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@patrick-ogrady patrick-ogrady changed the title feat(memory): make local capacity configurable feat(memory): make local record capacity configurable Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant