Fix FastAPI >= 0.137.0 compatibility with _IncludedRouter in route template resolution#107
Open
tpatzelt wants to merge 1 commit into
Open
Fix FastAPI >= 0.137.0 compatibility with _IncludedRouter in route template resolution#107tpatzelt wants to merge 1 commit into
tpatzelt wants to merge 1 commit into
Conversation
…stAPI >= 0.137.0 FastAPI >= 0.137.0 refactored include_router() to insert _IncludedRouter nodes into app.routes. These nodes have no .path attribute, causing AttributeError in get_full_or_template_path. Recursively walk their children via original_router.routes to preserve template URL support. Adds test coverage for included routers with the MetricsMiddleware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastAPI >= 0.137.0 refactored
include_router()to insert_IncludedRouternodes intoapp.routes. These nodes have no.pathattribute, causingAttributeErroringet_full_or_template_path.Changes
_match_route_template: New recursive method that walks_IncludedRouternodes viaoriginal_router.routesto preserve template URL support for included routes.get_full_or_template_path: Delegates to_match_route_templateinstead of directly iterating routes.tests/test_fastapi_compat.pywith three test cases covering included routers withMetricsMiddleware.