Fixes #10 #11
Fixes #10 #11
Conversation
There was a problem hiding this comment.
@xaviermarchegay .github/workflows/test.yml must be updated too.
|
Please upgrade Rector & php-cs-fixer config too. |
.github/workflows/test.yml
Outdated
|
|
||
| symfony-require: 7.4.* | ||
| variant: symfony/symfony:"7.4.*" | ||
| # - php-version: '8.4' |
| # allowed-to-fail: false | ||
| # symfony-require: 8.0.* | ||
| # variant: symfony/symfony:"8.0.*" | ||
| - php-version: '8.5' |
There was a problem hiding this comment.
Add - php-version: '8.5'
dependencies: highest
allowed-to-fail: false
symfony-require: 6.4.*
variant: symfony/symfony:"6.4.*"
.github/workflows/test.yml
Outdated
| allowed-to-fail: false | ||
| symfony-require: 7.4.* | ||
| variant: symfony/symfony:"7.4.*" | ||
| # - php-version: '8.5' |
.php-cs-fixer.dist.php
Outdated
| EOF; | ||
|
|
||
| return (new PhpCsFixer\Config()) | ||
| ->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect()) |
.github/workflows/test.yml
Outdated
| # - php-version: '8.4' | ||
| # dependencies: highest | ||
| # allowed-to-fail: false | ||
| # symfony-require: 8.0.* |
There was a problem hiding this comment.
Try symfony-require: 8.*
variant: symfony/symfony:"8.*"
rector.php
Outdated
| // here we can define what prepared sets of rules will be applied | ||
| ->withPreparedSets(deadCode: true, codeQuality: true, symfonyCodeQuality: true) | ||
| ->withAttributesSets(symfony: true) | ||
| ->withComposerBased(symfony: true) |
There was a problem hiding this comment.
This doesn't work on vendors because symfony version is multiple.
…` and update CHANGELOG
composer.json
Outdated
| "require": { | ||
| "php": ">=8.2", | ||
| "cleverage/process-bundle": "^4.0", | ||
| "cleverage/process-bundle": "^4.0|^5.0", |
There was a problem hiding this comment.
Only latest version of PB is supported. => "cleverage/process-bundle": "^5.0",
CHANGELOG.md
Outdated
|
|
||
| ### Changes | ||
| * [#10](https://github.com/cleverage/cache-process-bundle/issues/10) Add support for PHP 8.5 and Symfony 8.* Update phpunit/phpunit to version >10.0 | ||
| * [#10](https://github.com/cleverage/cache-process-bundle/issues/10) Add support for PHP 8.5 and Symfony 8.* Update phpunit/phpunit to version >10.0 Add support for cleverage/process-bundle ^5.0 |
There was a problem hiding this comment.
Add support for cleverage/process-bundle ^5.0 => Bump version to cleverage/process-bundle ^5.0
… only and adjust CHANGELOG accordingly
…prove readability
Description
Upgrades php and symfony
Requirements