Bump golangci lint and fix issues#121
Merged
Merged
Conversation
williammartin
force-pushed
the
wm-bump-golang-ci-lint
branch
from
4d7afb2 to
6892c09
Compare
babakks
approved these changes
May 20, 2026
There was a problem hiding this comment.
Pull request overview
Updates the repository’s linting setup to a newer golangci-lint configuration/action and adjusts a couple of tests to satisfy updated linter rules.
Changes:
- Migrate
.golangci.ymlto configversion: "2"and reorganize linter/formatter configuration. - Update the GitHub Actions lint workflow to use
golangci/golangci-lint-actionand astableGo toolchain. - Fix linter warnings in tests by marking unused parameters as
_.
Show a summary per file
| File | Description |
|---|---|
device/device_flow_test.go |
Marks an unused factory parameter as unused (_) to satisfy linting. |
api/form_test.go |
Marks unused PostForm parameters as unused (_) to satisfy linting. |
.golangci.yml |
Migrates to config v2 format and adjusts enabled linters/formatters. |
.github/workflows/lint.yml |
Switches linting to the official golangci-lint GitHub Action and updates Go setup. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 1
williammartin
force-pushed
the
wm-bump-golang-ci-lint
branch
from
6892c09 to
81dbd4d
Compare
williammartin
force-pushed
the
wm-bump-golang-ci-lint
branch
from
81dbd4d to
3c28b94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This repo was super out of date on some of this stuff.