Fix voice TTS for AI SDK textStream responses#1462
Merged
whoiskatrin merged 2 commits intomainfrom May 6, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: e06978f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
mattzcarey
approved these changes
May 6, 2026
Contributor
mattzcarey
left a comment
There was a problem hiding this comment.
looks good and makes sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
withVoicehandling of AI SDKstreamText(...).textStreamvalues returned fromonTurn().AI SDK
textStreamvalues are dual-protocol objects: they areReadableStreams and also expose a customSymbol.asyncIteratorthat yields string deltas.iterateText()previously checkedinstanceof ReadableStreamfirst, so these streams could be consumed through the generic stream parser instead of the AI SDK string iterator. That meant assistant text could be persisted while no text reached the sentence chunker/TTS pipeline, producing no spoken audio.This updates
iterateText()to prefer a custom/source-owned async iterator before falling back toReadableStreamparsing, while preserving the existing nativeReadableStream<string>andReadableStream<Uint8Array>SSE/NDJSON paths.Fixes #1364
Refs #1352
Changes
@cloudflare/voice.ReadableStreamparsing behavior intact for string streams and SSE/NDJSON byte streams.result.textStreamcan be returned directly fromonTurn().@cloudflare/voice.Testing
npm test -w @cloudflare/voicenpm run buildnpm run check