Skip to content

feat(tabs): add size="sm" variant#499

Merged
mattrothenberg merged 3 commits intomainfrom
feat/tabs-sm-variant
May 8, 2026
Merged

feat(tabs): add size="sm" variant#499
mattrothenberg merged 3 commits intomainfrom
feat/tabs-sm-variant

Conversation

@mattrothenberg
Copy link
Copy Markdown
Collaborator

@mattrothenberg mattrothenberg commented May 8, 2026

Summary

  • Adds size prop to Tabs with "base" (default) and "sm" options
  • size="sm" uses h-6.5 (26px) for both segmented and underline variants, matching Input size="sm" for aligned toolbars
  • Adds TabsSmDemo to Tabs doc page and LayerCardFilterSubrequestsDemo to LayerCard doc page showing Tabs sm + Input sm side-by-side in a filter toolbar
image
  • Reviews
  • bonk has reviewed the change
  • automated review not possible because: new feature needs visual review
  • Tests
  • Additional testing not necessary because: additive prop with no logic changes to existing behavior

Add size prop to Tabs with "base" (default) and "sm" options.
The sm variant uses h-6.5 (26px) for both segmented and underline,
matching Input size="sm" for aligned toolbars.

Includes demos on Tabs and LayerCard doc pages.
@mattrothenberg
Copy link
Copy Markdown
Collaborator Author

/bonk review

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review complete. Implementation follows all project conventions:

  • ✅ Proper KUMO_TABS_VARIANTS/KUMO_TABS_DEFAULT_VARIANTS exports
  • ✅ Semantic tokens throughout (no raw colors, no dark: prefixes)
  • ✅ h-6.5 height matches Input size="sm" for toolbar alignment
  • ✅ Both segmented and underline variants supported
  • ✅ Demos properly named and documented
  • ✅ Changeset correctly marked as minor

LGTM!

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 8, 2026

Posted approval on PR #499. The implementation is solid and ready to merge.

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 8, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@499

commit: 9eed9e1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Docs Preview

View docs preview

Commit: 1a47d35

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Visual Regression Report — 11 changed, 27 unchanged

11 screenshot(s) with visual changes:

Button / Basic

264 px (0.26%) changed

Before After Diff
Before After Diff

Button / Loading State

5 px (0%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

170 px (0.09%) changed

Before After Diff
Before After Diff

Select / Select Without Label

105 px (0.1%) changed

Before After Diff
Before After Diff

Select / Select With Field

635 px (0.54%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

418 px (0.41%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Multiple

801 px (0.79%) changed

Before After Diff
Before After Diff

Select / Select Grouped

407 px (0.4%) changed

Before After Diff
Before After Diff

Select (Open)

538 px (0%) changed

Before After Diff
Before After Diff
27 screenshot(s) unchanged
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Title
  • Button / Link as Button
  • Dialog / Dialog With Actions
  • Dialog / Dialog Basic
  • Dialog / Dialog Alert
  • Dialog / Dialog Confirmation
  • Dialog / Dialog With Select
  • Dialog / Dialog With Combobox
  • Dialog / Dialog With Dropdown
  • Select / Select Basic
  • Select / Select With Tooltip
  • Select / Select Custom Rendering
  • Select / Select Complex
  • Select / Select Disabled Options
  • Select / Select Disabled Items
  • Select / Select Grouped With Disabled
  • Select / Select Long List

Generated by Kumo Visual Regression

Copy link
Copy Markdown
Contributor

@najlaskr najlaskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me! just suggesting a few smol changes to the underline variant to mimic the targeted touch targets

Comment thread packages/kumo/src/components/tabs/tabs.tsx Outdated
Comment thread packages/kumo/src/components/tabs/tabs.tsx Outdated
Co-authored-by: Najla S <30641730+najlaskr@users.noreply.github.com>
@mattrothenberg mattrothenberg merged commit 59b6590 into main May 8, 2026
16 checks passed
@mattrothenberg mattrothenberg deleted the feat/tabs-sm-variant branch May 8, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants