feat(tabs): add size="sm" variant#499
Merged
mattrothenberg merged 3 commits intomainfrom May 8, 2026
Merged
Conversation
Add size prop to Tabs with "base" (default) and "sm" options. The sm variant uses h-6.5 (26px) for both segmented and underline, matching Input size="sm" for aligned toolbars. Includes demos on Tabs and LayerCard doc pages.
Collaborator
Author
|
/bonk review |
Contributor
There was a problem hiding this comment.
Code review complete. Implementation follows all project conventions:
- ✅ Proper KUMO_TABS_VARIANTS/KUMO_TABS_DEFAULT_VARIANTS exports
- ✅ Semantic tokens throughout (no raw colors, no dark: prefixes)
- ✅ h-6.5 height matches Input size="sm" for toolbar alignment
- ✅ Both segmented and underline variants supported
- ✅ Demos properly named and documented
- ✅ Changeset correctly marked as minor
LGTM!
Contributor
|
Posted approval on PR #499. The implementation is solid and ready to merge. |
commit: |
Contributor
Docs PreviewCommit: |
Contributor
rozenmd
approved these changes
May 8, 2026
pedromenezes1
approved these changes
May 8, 2026
najlaskr
reviewed
May 8, 2026
Contributor
najlaskr
left a comment
There was a problem hiding this comment.
looks great to me! just suggesting a few smol changes to the underline variant to mimic the targeted touch targets
Co-authored-by: Najla S <30641730+najlaskr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

































Summary
sizeprop toTabswith"base"(default) and"sm"optionssize="sm"usesh-6.5(26px) for both segmented and underline variants, matchingInput size="sm"for aligned toolbarsTabsSmDemoto Tabs doc page andLayerCardFilterSubrequestsDemoto LayerCard doc page showing Tabs sm + Input sm side-by-side in a filter toolbar