use correct this value for strategy.size
#5775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/fix-writable-streams-wpt-compliance
branch
from
11e5d0d to
bc7f8b3
Compare
anonrig
commented
Dec 26, 2025
jasnell
reviewed
Dec 26, 2025
anonrig
force-pushed
the
yagiz/fix-writable-streams-wpt-compliance
branch
2 times, most recently
from
d4c2761 to
35d31ef
Compare
guybedford
reviewed
Dec 29, 2025
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
How confident are we this is non breaking and shouldn't be grouped under a new pedantic auto-on flag group?
Member
Author
It's highly unlikely. @jasnell wdyt? |
Collaborator
|
This is unlikely to actually be breaking. |
jasnell
approved these changes
Dec 29, 2025
guybedford
approved these changes
Dec 29, 2025
anonrig
force-pushed
the
yagiz/fix-writable-streams-wpt-compliance
branch
from
35d31ef to
5f09b84
Compare
Member
Author
|
Rebased and force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streams spec is exteremely pedantic about certain things... Here's one of them. This changes makes the following test pass: WritableStream's strategy.size should not be called as a method