desiredSize should be null when the stream is erroring #5776
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Dec 26, 2025
jasnell
reviewed
Dec 26, 2025
anonrig
force-pushed
the
yagiz/fix-desiredSize
branch
from
a93109b to
8e5dd2e
Compare
guybedford
reviewed
Dec 29, 2025
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Conversely the to the previous PR, are we sure this will be breaking? Pedantic WPT not having a compat date is unfortunate for not auto-enabling?
Member
Author
I'm not following @guybedford |
Collaborator
|
This one is unlikely to actually be breaking but putting it behind the pedanticWpt flag also doesn't hurt. Should be ok either way. |
jasnell
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another web-platform tests requirements. I've put it behind pedanticWpt flag...