make sure the close algorithm always run async #5779
Merged
+57
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Dec 26, 2025
anonrig
force-pushed
the
yagiz/make-sure-algorithms-close
branch
from
ff9b347 to
19a9ecc
Compare
guybedford
reviewed
Dec 29, 2025
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Again, I wonder if this really needs to be a pedantic flag.
|
The generated output of |
anonrig
force-pushed
the
yagiz/make-sure-algorithms-close
branch
from
19a9ecc to
52a50ae
Compare
jasnell
reviewed
Dec 30, 2025
anonrig
force-pushed
the
yagiz/make-sure-algorithms-close
branch
from
52a50ae to
df7112e
Compare
anonrig
force-pushed
the
yagiz/make-sure-algorithms-close
branch
from
df7112e to
fa5342d
Compare
jasnell
reviewed
Dec 30, 2025
jasnell
approved these changes
Dec 30, 2025
Co-authored-by: James M Snell <[email protected]>
danlapid
pushed a commit
that referenced
this pull request
Dec 31, 2025
Co-authored-by: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put it behind pedanticWpt flag just in case it might break someone...