feat(d1): add IntoFuture and #[must_use] to D1PreparedStatement#1007
Merged
guybedford merged 3 commits intoJun 19, 2026
Merged
Conversation
A statement that never runs compiles fine but does nothing. Mark the type #[must_use] so that case is a compile warning, matching the KV builders.
Collaborator
|
For the For the |
Awaiting a prepared statement now runs it through run(), so callers can write `stmt.await?` instead of `stmt.run().await?`. Update the must_use note to mention await.
Contributor
Author
|
Added the |
guybedford
approved these changes
Jun 19, 2026
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D1PreparedStatementholds a query that has not run yet. With no terminal call it compiles fine and does nothing, e.g.query!(&db, "DELETE FROM users WHERE id = ?", id)?;. Adding#[must_use]to the type makes that a compile warning, matching the KV builders (GetOptionsBuilder,PutOptionsBuilder).#774 also asks for
impl IntoFutureso a statement runs when you.awaitit. That would be the firstIntoFuturein the crate, andawait stmthas to pick one terminal method. I can follow up with one delegating torun()to match the JSstmt.run(), orall()if you'd prefer.Part of #774.